Closed
Conversation
addresses ros-perception#272
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 21, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 21, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 21, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 24, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 24, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 24, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 24, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
eigendude
added a commit
to eigendude/meta-ros2
that referenced
this pull request
Nov 24, 2019
Patches from: github.com/ros-perception/vision_opencv/pull/288
Closed
Contributor
|
Isn't this a duplicate of #259 ? Considering opencv2 is not a target anymore of ROS melodic, we can clean up the code (and therefore complexity and make it more future proof) by removing the old module entirely. |
Merged
Contributor
|
Since ROS 1 is EOL now, closing this out. Thanks anyway for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #272